feat: support atomic batch transactions #30271

matthewwalsh0 · 2025-02-12T16:22:52Z

Description

Support atomic batch transactions via EIP-5792 and EIP-7702.

Specifically:

Upgrade @metamask/transaction-controller to support adding batch transactions.
Upgrade @metamask/eth-json-rpc-middleware to validate and process EIP-5792 RPC requests.
Patch @etheremjs/tx to fix nonce type in EIP-7702 authorizations.
Add EIP-5792 utils to provide hooks for middleware.
Add minimal support for TransactionType.batch in confirmations.

Related issues

Fixes #4209

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

matthewwalsh0 · 2025-02-13T11:10:01Z

@metamaskbot update-policies

socket-security · 2025-02-13T11:11:28Z

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] ➜ 15.3.0	None	`0`	196 kB	gudahtt
npm/@metamask/[email protected] ➜ 48.0.0-preview-22387993	None	`0`	0 B

View full report↗︎

metamaskbot · 2025-02-13T11:22:29Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

matthewwalsh0 · 2025-02-19T00:22:44Z

@metamaskbot update-policies

metamaskbot · 2025-02-19T00:35:04Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

matthewwalsh0 · 2025-02-19T01:11:04Z

@metamaskbot update-policies

metamaskbot · 2025-02-19T01:23:37Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-02-20T00:20:51Z

Builds ready [d9364b5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1708 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	1991	1537	418	201
		domContentLoaded	1455	2475	1687	212	102
		load	1465	2489	1708	210	101
		domInteractive	15	175	57	47	23
		backgroundConnect	9	59	25	16	8
		firstReactRender	14	67	34	22	11
		getState	4	67	27	24	12
		initialActions	0	1	0	0	0
		loadScripts	1042	1929	1264	180	86
		setupStore	7	72	16	17	8
		uiStartup	1719	2910	1984	256	123

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.2 MiB (-19.67%)
ui: -40.9 KiB (-0.54%)
common: -1.12 MiB (-12.29%)

metamaskbot · 2025-02-20T00:26:21Z

Builds ready [d9364b5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1708 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	1991	1537	418	201
		domContentLoaded	1455	2475	1687	212	102
		load	1465	2489	1708	210	101
		domInteractive	15	175	57	47	23
		backgroundConnect	9	59	25	16	8
		firstReactRender	14	67	34	22	11
		getState	4	67	27	24	12
		initialActions	0	1	0	0	0
		loadScripts	1042	1929	1264	180	86
		setupStore	7	72	16	17	8
		uiStartup	1719	2910	1984	256	123

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.2 MiB (-19.67%)
ui: -40.9 KiB (-0.54%)
common: -1.12 MiB (-12.29%)

metamaskbot · 2025-02-20T07:59:34Z

Builds ready [11fd386]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1799 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	294	2076	1589	530	254
		domContentLoaded	1506	2068	1773	145	69
		load	1510	2081	1799	149	71
		domInteractive	25	207	41	39	19
		backgroundConnect	8	84	29	21	10
		firstReactRender	14	73	40	25	12
		getState	4	74	21	24	11
		initialActions	0	1	0	0	0
		loadScripts	1047	1531	1339	133	64
		setupStore	7	14	10	2	1
		uiStartup	1758	2372	2078	168	81

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.2 MiB (-19.67%)
ui: -40.9 KiB (-0.54%)
common: -1.12 MiB (-12.29%)

metamaskbot · 2025-02-20T16:11:17Z

Builds ready [0e2b89e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1649 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	263	1808	1587	317	152
		domContentLoaded	1460	1796	1624	98	47
		load	1466	1834	1649	104	50
		domInteractive	24	264	53	51	25
		backgroundConnect	6	59	27	16	8
		firstReactRender	14	74	31	22	10
		getState	5	71	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1079	1410	1233	92	44
		setupStore	8	58	20	19	9
		uiStartup	1697	2089	1910	107	51

Bundle size diffs [🚀 Bundle size reduced!]

background: -649.08 KiB (-11.32%)
ui: 380 Bytes (0.00%)
common: -376.08 KiB (-4.40%)

socket-security · 2025-02-27T23:10:45Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

matthewwalsh0 · 2025-02-27T23:53:00Z

@metamaskbot update-policies

metamaskbot · 2025-02-28T00:05:42Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

matthewwalsh0 · 2025-03-03T21:30:12Z

@metamaskbot update-policies

metamaskbot · 2025-03-03T21:43:12Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

github-actions · 2025-03-06T20:46:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-07T15:30:17Z

Builds ready [41eade6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1863 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1585	2354	1857	197	94
		domContentLoaded	1570	2199	1804	163	78
		load	1585	2440	1863	210	101
		domInteractive	25	134	48	32	15
		backgroundConnect	9	325	61	66	32
		firstReactRender	15	119	33	27	13
		getState	6	205	29	44	21
		initialActions	0	1	0	0	0
		loadScripts	1176	1678	1378	132	63
		setupStore	8	65	21	19	9
		uiStartup	1859	4143	2229	480	230

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 76.42 KiB (1.24%)
ui: 128 Bytes (0.00%)
common: 15.89 KiB (0.15%)

metamaskbot · 2025-03-07T17:37:10Z

Builds ready [ad4e096]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2073 ± 444 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	527	2056	1775	310	149
		domContentLoaded	1660	6015	2031	924	444
		load	1702	6050	2073	924	444
		domInteractive	26	367	51	74	36
		backgroundConnect	11	136	52	31	15
		firstReactRender	15	97	36	23	11
		getState	6	60	23	17	8
		initialActions	0	1	0	0	0
		loadScripts	1249	4980	1560	794	381
		setupStore	8	53	15	11	6
		uiStartup	1938	6689	2384	1005	482

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 76.42 KiB (1.24%)
ui: 128 Bytes (0.00%)
common: 15.73 KiB (0.15%)

adonesky1 · 2025-03-07T19:00:40Z

app/scripts/lib/transaction/eip5792.ts

+  transactionController: TransactionController,
+  networkController: NetworkController,


Might it make more sense / match our existing patterns better to pass in hooks to the actual methods you're calling rather than the full controllers?

Good point, it definitely would.

In a future PR, we could even just pass in the messenger and invoke the controllers using the messenger actions.

adonesky1 · 2025-03-07T19:59:45Z

app/scripts/lib/transaction/eip5792.ts

+    throw rpcErrors.invalidInput(
+      `Chain ID must match the dApp selected network: Got ${requestChainId}, expected ${dappChainId}`,
+    );


Hmmmm I'm not sure if this is the right rpc error... Though I'm looking at the others and this may be our best match 🤔

This is our standard bad input error we use for all the transaction and signature calls from eth-json-rpc-middleware.

Though the EIP-5792 specification is still being finalised and I believe they're looking at formalising error codes for different scenarios so will likely extend this in future.

adonesky1 · 2025-03-07T20:00:59Z

app/scripts/lib/transaction/eip5792.ts

+}
+
+export function getTransactionReceiptsByBatchId(
+  controller: TransactionController,


Same thing here: could we just pass a method in rather than the whole controller?

adonesky1 · 2025-03-07T20:01:40Z

app/scripts/lib/transaction/eip5792.ts

+}
+
+export async function getCapabilities(
+  controller: TransactionController,


And same here: could we pass in a method rather than the whole controller?

metamaskbot · 2025-03-07T20:49:27Z

Builds ready [28dccab]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1882 ± 128 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1553	2472	1894	276	133
		domContentLoaded	1547	2307	1820	210	101
		load	1552	2406	1882	267	128
		domInteractive	24	70	35	14	7
		backgroundConnect	9	307	65	69	33
		firstReactRender	14	67	33	20	10
		getState	4	161	28	39	19
		initialActions	0	0	0	0	0
		loadScripts	1143	1799	1388	184	88
		setupStore	7	59	18	16	8
		uiStartup	1792	3633	2275	505	242

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 76.42 KiB (1.24%)
ui: 128 Bytes (0.00%)
common: 15.77 KiB (0.15%)

Support batch transaction type.

metamaskbot · 2025-03-07T22:17:46Z

Builds ready [e38a988]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2004 ± 125 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1735	2710	2013	256	123
		domContentLoaded	1723	2558	1954	228	109
		load	1728	2733	2004	261	125
		domInteractive	27	106	40	20	10
		backgroundConnect	10	174	53	46	22
		firstReactRender	15	74	30	19	9
		getState	6	122	33	35	17
		initialActions	0	1	0	0	0
		loadScripts	1288	1919	1483	179	86
		setupStore	7	63	26	21	10
		uiStartup	1993	3747	2367	466	224

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 76.64 KiB (1.25%)
ui: 128 Bytes (0.00%)
common: 15.77 KiB (0.15%)

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Feb 12, 2025

matthewwalsh0 changed the title ~~feat: support atomic batch transactions via EIP-5792~~ feat: support atomic batch transactions Feb 18, 2025

matthewwalsh0 force-pushed the feat/atomic-batch-transactions branch from f377c94 to 29af3c0 Compare February 18, 2025 23:59

matthewwalsh0 changed the base branch from main to mikesposito/bump-keyring-controller March 4, 2025 10:15

Base automatically changed from mikesposito/bump-keyring-controller to main March 7, 2025 11:15

adonesky1 reviewed Mar 7, 2025

View reviewed changes

Add 5792 middleware hooks

e38a988

Support batch transaction type.

matthewwalsh0 force-pushed the feat/atomic-batch-transactions branch from eb51b9c to e38a988 Compare March 7, 2025 21:43

matthewwalsh0 marked this pull request as ready for review March 7, 2025 22:34

matthewwalsh0 requested review from a team as code owners March 7, 2025 22:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support atomic batch transactions #30271

feat: support atomic batch transactions #30271

matthewwalsh0 commented Feb 12, 2025 •

edited

Loading

matthewwalsh0 commented Feb 13, 2025

socket-security bot commented Feb 13, 2025 •

edited

Loading

metamaskbot commented Feb 13, 2025

matthewwalsh0 commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

matthewwalsh0 commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

socket-security bot commented Feb 27, 2025 •

edited

Loading

matthewwalsh0 commented Feb 27, 2025

metamaskbot commented Feb 28, 2025

matthewwalsh0 commented Mar 3, 2025

metamaskbot commented Mar 3, 2025

github-actions bot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

adonesky1 Mar 7, 2025

matthewwalsh0 Mar 7, 2025

matthewwalsh0 Mar 7, 2025

adonesky1 Mar 7, 2025

matthewwalsh0 Mar 7, 2025 •

edited

Loading

adonesky1 Mar 7, 2025 •

edited

Loading

matthewwalsh0 Mar 7, 2025

adonesky1 Mar 7, 2025

matthewwalsh0 Mar 7, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

		transactionController: TransactionController,
		networkController: NetworkController,

feat: support atomic batch transactions #30271

Are you sure you want to change the base?

feat: support atomic batch transactions #30271

Conversation

matthewwalsh0 commented Feb 12, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

matthewwalsh0 commented Feb 13, 2025

socket-security bot commented Feb 13, 2025 • edited Loading

metamaskbot commented Feb 13, 2025

matthewwalsh0 commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

matthewwalsh0 commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 20, 2025

socket-security bot commented Feb 27, 2025 • edited Loading

matthewwalsh0 commented Feb 27, 2025

metamaskbot commented Feb 28, 2025

matthewwalsh0 commented Mar 3, 2025

metamaskbot commented Mar 3, 2025

github-actions bot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

adonesky1 Mar 7, 2025

Choose a reason for hiding this comment

matthewwalsh0 Mar 7, 2025

Choose a reason for hiding this comment

matthewwalsh0 Mar 7, 2025

Choose a reason for hiding this comment

adonesky1 Mar 7, 2025

Choose a reason for hiding this comment

matthewwalsh0 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

adonesky1 Mar 7, 2025 • edited Loading

Choose a reason for hiding this comment

matthewwalsh0 Mar 7, 2025

Choose a reason for hiding this comment

adonesky1 Mar 7, 2025

Choose a reason for hiding this comment

matthewwalsh0 Mar 7, 2025

Choose a reason for hiding this comment

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

matthewwalsh0 commented Feb 12, 2025 •

edited

Loading

socket-security bot commented Feb 13, 2025 •

edited

Loading

socket-security bot commented Feb 27, 2025 •

edited

Loading

matthewwalsh0 Mar 7, 2025 •

edited

Loading

adonesky1 Mar 7, 2025 •

edited

Loading